From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvoGX-00056o-He for qemu-devel@nongnu.org; Thu, 17 Jan 2013 07:08:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvoGW-0005Ln-7E for qemu-devel@nongnu.org; Thu, 17 Jan 2013 07:08:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvoGV-0005Lj-VV for qemu-devel@nongnu.org; Thu, 17 Jan 2013 07:08:16 -0500 Message-ID: <50F7E9AC.9040207@redhat.com> Date: Thu, 17 Jan 2013 13:08:12 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1355580573-19323-1-git-send-email-sw@weilnetz.de> <1355580573-19323-5-git-send-email-sw@weilnetz.de> In-Reply-To: <1355580573-19323-5-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block/vdi: Improved return values from vdi_open and other small fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Am 15.12.2012 15:09, schrieb Stefan Weil: > vdi_open returned -1 in case of any error, but it should return an > error code (negative value of errno or BDRV_WRONG_FORMAT). > > vdi_open did not check for a bad signature. This check was only in vdi_probe. > > The signature is a 32 bit value and needs up to 8 hex digits for printing. > > Signed-off-by: Stefan Weil Sounds like three independent changes and should be three patches therefore. Kevin