From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvpm2-0002vi-D6 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:44:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvpm1-0005Rh-4A for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:44:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvpm0-0005Rb-Sv for qemu-devel@nongnu.org; Thu, 17 Jan 2013 08:44:53 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HDiqKB011547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jan 2013 08:44:52 -0500 Message-ID: <50F80052.4050307@redhat.com> Date: Thu, 17 Jan 2013 14:44:50 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1487580585.10884389.1358429291926.JavaMail.root@redhat.com> In-Reply-To: <1487580585.10884389.1358429291926.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Hi, >> I think it would also be good to fix the driver to ignore everything >> with or > ... what was the end of that sentence? .. orientation != 0, then registers every mode with the orientations it wants, so orientation becomes unused with newer drivers (and we keep orientation=0,1 for old driver compatibility). But maybe this isn't worth the trouble. cheers, Gerd