From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead of open-coding them
Date: Thu, 17 Jan 2013 17:51:05 +0400 [thread overview]
Message-ID: <50F801C9.6000909@msgid.tls.msk.ru> (raw)
In-Reply-To: <20130117130615.GB6830@stefanha-thinkpad.redhat.com>
17.01.2013 17:06, Stefan Hajnoczi wrote:
> On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
>> We have iov_from_buf() and iov_to_buf(), use them instead of
>> open-coding these in block/win32-aio.c
>
> Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
> operating on a QEMUIOVector.
I'd remove qemu_iovec_{from,to}_buf() completely at this point
due to their trivialness and almost no gain in usage as polluting
the namespace (having too many trivial utility functions isn't
good). Right now these are only used in one place - in
hw/dataplane/virtio-blk.c .
If not, we can at least inline them.
Thanks,
/mjt
next prev parent reply other threads:[~2013-01-17 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 10:44 [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead of open-coding them Michael Tokarev
2013-01-17 13:06 ` Stefan Hajnoczi
2013-01-17 13:51 ` Michael Tokarev [this message]
2013-01-18 8:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F801C9.6000909@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).