From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrYL-0004MP-7T for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:38:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvrYF-0002H9-Jq for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:38:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrYF-0002Gt-9h for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:38:47 -0500 Message-ID: <50F81AF5.5010804@redhat.com> Date: Thu, 17 Jan 2013 08:38:29 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358353508-5369-1-git-send-email-benoit@irqsave.net> <1358353508-5369-11-git-send-email-benoit@irqsave.net> <20130117121543.GC3448@irqsave.net> In-Reply-To: <20130117121543.GC3448@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QVXDSPEXLFBVVIHNESQI" Subject: Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QVXDSPEXLFBVVIHNESQI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/17/2013 05:15 AM, Beno=C3=AEt Canet wrote: >> +# @running: True if deduplication is running >=20 > Internally QCOW2 deduplication state switch between STOPPED, STARTING, = RUNNING > and STOPPING. >=20 > Should the running field be a status field reflecting all theses states= in a > string for example ? > Or is the boolean ok ? Outputting an enum of all four states may be the best for debugging purposes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QVXDSPEXLFBVVIHNESQI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+Br2AAoJEKeha0olJ0NqAFsH+waoXzcr28AdusE3iu6kH03K sGXD2aUNZWrL9XHyg8zEprOfW49ygl4qRFhNvjJP+XSkCzPCtnouiWwVwx3IKOFA ellDL7KuA7sLDCcyFZ8M1L/od8FFqr+12g4plWUyHRQtm3LL1ze72UCrrD/+U4xA i0MN8HvN/XBb3J7P2sVeJ/dKv+Lp/ZwKcrdKRy9jnhISb5K4ej5itpTLhdWio9Il JJ1K2ivUmokuIGq55aa+69A3DlioDzU9TYzjRDRXSwW9SIAVJz+fq7lAwd5o/nq4 of49ry0ed2Mw/ylYBPFQzvbwM3y1zKPe5qn2o9xRrzUpMZTNQZ+hcZ9+KGMvSL4= =y0Rf -----END PGP SIGNATURE----- ------enig2QVXDSPEXLFBVVIHNESQI--