From: Stefan Weil <sw@weilnetz.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW
Date: Thu, 17 Jan 2013 21:54:02 +0100 [thread overview]
Message-ID: <50F864EA.1080800@weilnetz.de> (raw)
In-Reply-To: <CAAu8pHsm8-kPYEDH=9RoAmuENm_dVLorqLkugmLvNN8rQuP1pA@mail.gmail.com>
Am 17.01.2013 21:45, schrieb Blue Swirl:
> On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil<sw@weilnetz.de> wrote:
>> MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h.
>> We must also fix the include statements in util/envlist.c to include
>> that file.
>>
>> We currently don't need an implementation of strtok_r because the
>> code is compiled but not linked for MinGW.
>
> I think it would be better to fix the build system so that unnecessary
> files are not compiled.
That's what I suggested first, but keeping things simple is also
a good argument. Perhaps we should accept that libqemuutil.a
can contain some unnecessary files (that's the status quo!).
We also get the additional benefit of more portable code.
Even if that portability is not needed for the moment,
it might be useful later.
Stefan
next prev parent reply other threads:[~2013-01-17 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 18:04 [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW Stefan Weil
2013-01-17 20:45 ` Blue Swirl
2013-01-17 20:54 ` Stefan Weil [this message]
2013-01-17 21:18 ` Blue Swirl
2013-01-18 8:36 ` Paolo Bonzini
2013-01-19 8:59 ` Blue Swirl
2013-02-03 16:15 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F864EA.1080800@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).