From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvx0y-0007qs-St for qemu-devel@nongnu.org; Thu, 17 Jan 2013 16:28:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvx0x-00076V-NL for qemu-devel@nongnu.org; Thu, 17 Jan 2013 16:28:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvx0x-00076P-E8 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 16:28:47 -0500 Message-ID: <50F86D0D.7030104@redhat.com> Date: Thu, 17 Jan 2013 14:28:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358455528-29813-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1358455528-29813-1-git-send-email-sw@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DOHRWQEUOERKHCARSNUD" Subject: Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DOHRWQEUOERKHCARSNUD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/17/2013 01:45 PM, Stefan Weil wrote: > These patches improve the error report if the file format was > specified explicitly (example: -drive file=3Dmyfile,format=3Dqcow2) > and the given format does not match the real format. >=20 > They fix those bugs: >=20 > https://bugzilla.redhat.com/show_bug.cgi?id=3D556482 > https://bugs.launchpad.net/qemu/+bug/1090600 >=20 > Changes in v2: >=20 > * Use error code EMEDIUMTYPE instead of inventing a new one. Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux. If you are providing fallbacks for half the platforms because you don't want to use a standard errno value, then why not go all the way and use a fallback for all platforms. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DOHRWQEUOERKHCARSNUD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+G0NAAoJEKeha0olJ0NquRsH/0swsgfLo8L+pKv4WSVpneeJ s0doGnpvHU/5qDKFrYaAYoE1S8kGznMijlzh2YPzt/fqBpfl99W6y+HSmPy0GRPR Wm53FiLBS3+ZS28RmQJPcItL7ue8JakLBhVDZmaBexd8SJAsc8paQiQ0z4DhDmbO nryJri57+BIUtF80iPA6/4RzZ4pHAqA4qcw/oR3fa7tFfzSwTmLwPSVj14xSFydx fRkZKqOU6RRcySzhUJVSCWtu+MPx9RRxrzDPeUsEGDmdLGbos6kXL9xMfgzqUq/s cnkBw9fQYj6JlZxxmxk1nATuCcN1faRwkTMPWHK0UP9db1OTRyFZpXIBEQnmIbM= =VEPB -----END PGP SIGNATURE----- ------enig2DOHRWQEUOERKHCARSNUD--