From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvxs0-0000Jv-I4 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:23:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvxrz-0004Zl-DE for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:23:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvxrz-0004Za-5b for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:23:35 -0500 Message-ID: <50F879E1.2060507@redhat.com> Date: Thu, 17 Jan 2013 15:23:29 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358437897-24251-1-git-send-email-benoit@irqsave.net> <1358437897-24251-8-git-send-email-benoit@irqsave.net> In-Reply-To: <1358437897-24251-8-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TLVCTTVUXIKFEWXVSBVT" Subject: Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TLVCTTVUXIKFEWXVSBVT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/17/2013 08:51 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 278 ++++++++++++++++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 277 insertions(+), 1 deletion(-) >=20 > diff --git a/block/quorum.c b/block/quorum.c > index 98052eb..2bffff4 100644 > --- a/block/quorum.c > +++ b/block/quorum.c > @@ -14,6 +14,20 @@ > */ > =20 > #include "block/block_int.h" > +#include "zlib.h" Since zlib.h isn't part of qemu.git, this should be . > + > +static unsigned long quorum_compute_checksum(QuorumAIOCB *acb, int i) > +{ > + int j; > + unsigned long adler =3D adler32(0L, Z_NULL, 0); Hmm, adler32() is basically a weak hashing mechanism; are you sure you won't have any false collisions? Furthermore, how does this compare with the series for adding deduplication, which uses much stronger/longer hashes, but where those take more time to compute? Is there any way you can share efforts between the two series? > + /* get the index of the first successfull read */ s/successfull/successful/ (several times in this patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TLVCTTVUXIKFEWXVSBVT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+HnhAAoJEKeha0olJ0NqWTMH/ivgFl01lDPV3TQvgsbcWPgr 1+vqrUZdRAlHpn2DUXmopMzSIb2OxMmaYUm87FUoMOoZkRi1KkNYQ2jRsBw+HvWB LtPcxtK5PbJoJK3AO1yjAVssz1Q2tCSHYrb+9RHpU6kBQprDQ7lT7sMrwRVxlj4B 1kqNdwyBxyqMis5oKSCqHiE/qKvjYcUx6yTZd+dJ5IaVBobL5nVZ66ZgSW5V6Nvi A3YGjt+aXbxjHu8hgmHkgACcrxoMRH+pvM4Sxh9cQSwX6bvI+gbOt7DgG1StTpnj 6r2j7iG1xGW7UCdtVi/R0j1IGmvSlenxG+dhjq13Q10Bui6t4xhdaSrlFGAiEns= =Iy4d -----END PGP SIGNATURE----- ------enig2TLVCTTVUXIKFEWXVSBVT--