Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On 01/17/2013 03:25 PM, Stefan Weil wrote:

>>> * Use error code EMEDIUMTYPE instead of inventing a new one.
>>>      
>> Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux.
>> If you are providing fallbacks for half the platforms because you don't
>> want to use a standard errno value, then why not go all the way and use
>> a fallback for all platforms.
>>    
> 
> That's what I did in v1 of my patches: it used BDRV_WRONG_FORMAT.
> 
> I didn't introduce a EFILEFORMAT because it looks like
> something used outside of the QEMU world (which is not true).
> 
> If EFILEFORMAT (or any other new name) is preferred,
> I won't object. In this case, I can either send a new patch series,
> or whoever commits my patches can do a simple replace operation.

Fair enough; I won't hold up the patch series over a bikeshed choice of
error naming.  So with that:

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]