From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvy9W-0007To-1y for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:41:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvy9I-00013s-N8 for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:41:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvy9I-00013o-Ea for qemu-devel@nongnu.org; Thu, 17 Jan 2013 17:41:28 -0500 Message-ID: <50F87E04.3050505@redhat.com> Date: Thu, 17 Jan 2013 15:41:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358455528-29813-1-git-send-email-sw@weilnetz.de> <50F86D0D.7030104@redhat.com> <50F87A53.7080108@weilnetz.de> In-Reply-To: <50F87A53.7080108@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2DRRAIGSEAMMLMEIDGXSP" Subject: Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2DRRAIGSEAMMLMEIDGXSP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/17/2013 03:25 PM, Stefan Weil wrote: >>> * Use error code EMEDIUMTYPE instead of inventing a new one. >>> =20 >> Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux.= >> If you are providing fallbacks for half the platforms because you don'= t >> want to use a standard errno value, then why not go all the way and us= e >> a fallback for all platforms. >> =20 >=20 > That's what I did in v1 of my patches: it used BDRV_WRONG_FORMAT. >=20 > I didn't introduce a EFILEFORMAT because it looks like > something used outside of the QEMU world (which is not true). >=20 > If EFILEFORMAT (or any other new name) is preferred, > I won't object. In this case, I can either send a new patch series, > or whoever commits my patches can do a simple replace operation. Fair enough; I won't hold up the patch series over a bikeshed choice of error naming. So with that: Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2DRRAIGSEAMMLMEIDGXSP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+H4EAAoJEKeha0olJ0NqwYwH/jby2We1gwU5eTtVJdAenWhu SrY983SETE7DojWe4fFdIUNCAuAZDJF6QB3OyW/nTKqLmTU9eayQg7OnpaS63qw6 efqvfFIcWwX7ixluWsS/s+tHkQujKIQan9/iPLtCIp1AeqyejsOyWWVstT+0yHyb Eo4Q+5ttAIFxxEpoBSp/zpiq+fkF1DHePpLmL+QIHdHUp/adepY2AVbEW2FY3SEc V2UqGWPz2AWq4YQyk7jEmpw66shHKO1u6yl0aTek8tgfxUaGDa+n8/9/WU8cU2lr IDnzabI52BtGqJtUjL/28n+NgM/lQxcYj8ADdle0CCgSTbuH+0BP0j/PRQvcTuY= =ZStf -----END PGP SIGNATURE----- ------enig2DRRAIGSEAMMLMEIDGXSP--