From: "Andreas Färber" <afaerber@suse.de>
To: Dante <dantesu@faraday-tech.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller
Date: Fri, 18 Jan 2013 11:53:22 +0100 [thread overview]
Message-ID: <50F929A2.2010608@suse.de> (raw)
In-Reply-To: <1358490616-18417-1-git-send-email-dantesu@faraday-tech.com>
Am 18.01.2013 07:30, schrieb Dante:
> Signed-off-by: Kuo-Jung Su <dantesu@faraday-tech.com>
These patches are all for QEMU so please generally drop "QEMU model for"
from the subject for readability.
> ---
> hw/fti2c010.c | 209 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> hw/fti2c010.h | 77 +++++++++++++++++++++
> 2 files changed, 286 insertions(+)
> create mode 100644 hw/fti2c010.c
> create mode 100644 hw/fti2c010.h
This adds two files but misses to add them to a Makefile so that this
patch can actually be compile-tested.
I have recently added a test framework for I2C. Can you please add such
libqos support as tests/libi2c-fti2c010.c as a follow-up patch if you
haven't already somewhere in this series? This suggests similar
preparations as for the RTC, in this case extracting constants from
fti2c010.h to an fti2c010_regs.h while putting the QOM macros and
optionally state struct (if it is to be embedded in some other chipset)
into fti2c010.h.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-01-18 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 6:30 [Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller Dante
2013-01-18 10:53 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F929A2.2010608@suse.de \
--to=afaerber@suse.de \
--cc=dantesu@faraday-tech.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).