From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tw9Zi-0000AV-9N for qemu-devel@nongnu.org; Fri, 18 Jan 2013 05:53:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tw9Zh-0005Sk-82 for qemu-devel@nongnu.org; Fri, 18 Jan 2013 05:53:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60895 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tw9Zg-0005Sb-VS for qemu-devel@nongnu.org; Fri, 18 Jan 2013 05:53:29 -0500 Message-ID: <50F929A2.2010608@suse.de> Date: Fri, 18 Jan 2013 11:53:22 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1358490616-18417-1-git-send-email-dantesu@faraday-tech.com> In-Reply-To: <1358490616-18417-1-git-send-email-dantesu@faraday-tech.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dante Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, paul@codesourcery.com Am 18.01.2013 07:30, schrieb Dante: > Signed-off-by: Kuo-Jung Su These patches are all for QEMU so please generally drop "QEMU model for" from the subject for readability. > --- > hw/fti2c010.c | 209 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > hw/fti2c010.h | 77 +++++++++++++++++++++ > 2 files changed, 286 insertions(+) > create mode 100644 hw/fti2c010.c > create mode 100644 hw/fti2c010.h This adds two files but misses to add them to a Makefile so that this patch can actually be compile-tested. I have recently added a test framework for I2C. Can you please add such libqos support as tests/libi2c-fti2c010.c as a follow-up patch if you haven't already somewhere in this series? This suggests similar preparations as for the RTC, in this case extracting constants from fti2c010.h to an fti2c010_regs.h while putting the QOM macros and optionally state struct (if it is to be embedded in some other chipset) into fti2c010.h. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg