From: "Andreas Färber" <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
Chegu Vinod <chegu_vinod@hp.com>,
Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions
Date: Fri, 18 Jan 2013 14:32:54 +0100 [thread overview]
Message-ID: <50F94F06.9040805@suse.de> (raw)
In-Reply-To: <20130118132646.GW10683@otherpad.lan.raisama.net>
Am 18.01.2013 14:26, schrieb Eduardo Habkost:
>
> On Fri, Jan 18, 2013 at 11:01:14AM +0100, Markus Armbruster wrote:
>> Your list of error checks isn't quite complete. Here's my try:
Even better would be:
>> /**
* parse_uint:
>> * @s: String to parse
>> * @value: Destination for parsed integer value
>> * @endptr: Destination for pointer to first character not consumed
>> * @base: integer base, between 2 and 36 inclusive, or 0
>> *
* Parse unsigned integer
>> * Parsed syntax is just like strol()'s: arbitrary whitespace, a single
>> * optional '+' or '-', an optional "0x" if @base is 0 or 16, one or
>> * more digits.
[snip]
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-18 13:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 18:28 [Qemu-devel] [PATCH 0/8] -numa option parsing fixes (v3) Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions Eduardo Habkost
2013-01-17 18:29 ` Laszlo Ersek
2013-01-17 18:50 ` Eduardo Habkost
2013-01-17 19:06 ` [Qemu-devel] [PATCH 1/8 v4] " Eduardo Habkost
2013-01-17 19:25 ` Eduardo Habkost
2013-01-17 19:31 ` Laszlo Ersek
2013-01-17 19:55 ` Eric Blake
2013-01-17 21:04 ` Blue Swirl
2013-01-18 10:01 ` [Qemu-devel] [PATCH 1/8] " Markus Armbruster
2013-01-18 13:26 ` Eduardo Habkost
2013-01-18 13:32 ` Andreas Färber [this message]
2013-01-18 17:57 ` [Qemu-devel] [PATCH 1/8 v5] " Eduardo Habkost
2013-01-18 18:11 ` Eric Blake
2013-01-18 19:41 ` [Qemu-devel] [PATCH 1/8 v6] " Eduardo Habkost
2013-01-18 20:20 ` Eric Blake
2013-01-18 18:06 ` [Qemu-devel] [PATCH 1/8] " Markus Armbruster
2013-01-16 18:28 ` [Qemu-devel] [PATCH 2/8] vl.c: Fix off-by-one bug when handling "-numa node" argument Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 3/8] vl.c: Abort on unknown -numa option type Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 4/8] vl.c: Check for NUMA node limit inside numa_add() Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 5/8] vl.c: numa_add(): Validate nodeid before using it Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 7/8] vl.c: Extract -numa "cpus" parsing to separate function Eduardo Habkost
2013-01-16 18:28 ` [Qemu-devel] [PATCH 8/8] vl.c: validate -numa "cpus" parameter properly Eduardo Habkost
2013-01-16 20:07 ` [Qemu-devel] [PATCH 0/8] -numa option parsing fixes (v3) Eric Blake
[not found] ` <20130128165559.GA6849@otherpad.lan.raisama.net>
[not found] ` <20130131154227.GH6849@otherpad.lan.raisama.net>
2013-02-01 20:45 ` [Qemu-devel] [PATCH for-1.4 " Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-01-16 15:24 [Qemu-devel] [PATCH 0/8] -numa option parsing fixes (v2) Eduardo Habkost
2013-01-16 15:24 ` [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions Eduardo Habkost
2013-01-16 17:10 ` Eric Blake
2013-01-16 17:33 ` Eduardo Habkost
2013-01-16 17:50 ` Eric Blake
2013-01-16 17:56 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F94F06.9040805@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=ehabkost@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).