From: Liu Yuan <namei.unix@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected
Date: Sat, 19 Jan 2013 00:28:31 +0800 [thread overview]
Message-ID: <50F9782F.5090401@gmail.com> (raw)
In-Reply-To: <CAJSP0QU6tyNceuBGP-v=3wFWGFPnNROr71EUOiUT7+-fiOnzXg@mail.gmail.com>
On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote:
> How are you checking that sd_co_flush_to_disk() is called? Please
> post the diff.
Okay, this is where I added printf().
Yuan
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 3e49bb8..41edd46 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1714,6 +1714,7 @@ static int coroutine_fn
sd_co_flush_to_disk(BlockDriverState *bs)
AIOReq *aio_req;
int ret;
+ printf("hello\n");
if (s->cache_flags != SD_FLAG_CMD_CACHE) {
return 0;
}
next prev parent reply other threads:[~2013-01-18 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 15:43 [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected Liu Yuan
2013-01-18 15:56 ` Stefan Hajnoczi
2013-01-18 16:13 ` Liu Yuan
2013-01-18 16:28 ` Liu Yuan [this message]
2013-01-18 18:06 ` Liu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F9782F.5090401@gmail.com \
--to=namei.unix@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).