From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1TwEo9-0000uQ-4D
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1TwEo5-0004hh-53
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:45 -0500
Received: from mail-pb0-f43.google.com ([209.85.160.43]:54026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1TwEo4-0004hJ-Vd
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:41 -0500
Received: by mail-pb0-f43.google.com with SMTP id jt11so763631pbb.30
	for <qemu-devel@nongnu.org>; Fri, 18 Jan 2013 08:28:40 -0800 (PST)
Message-ID: <50F9782F.5090401@gmail.com>
Date: Sat, 19 Jan 2013 00:28:31 +0800
From: Liu Yuan <namei.unix@gmail.com>
MIME-Version: 1.0
References: <50F96D92.6080301@gmail.com>
	<CAJSP0QU6tyNceuBGP-v=3wFWGFPnNROr71EUOiUT7+-fiOnzXg@mail.gmail.com>
In-Reply-To: <CAJSP0QU6tyNceuBGP-v=3wFWGFPnNROr71EUOiUT7+-fiOnzXg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote:
> How are you checking that sd_co_flush_to_disk() is called?  Please
> post the diff.

Okay, this is where I added printf().

Yuan

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 3e49bb8..41edd46 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1714,6 +1714,7 @@ static int coroutine_fn
sd_co_flush_to_disk(BlockDriverState *bs)
     AIOReq *aio_req;
     int ret;

+    printf("hello\n");
     if (s->cache_flags != SD_FLAG_CMD_CACHE) {
         return 0;
     }