From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TwGpH-0005Zl-Dg
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 13:38:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TwGpF-0005OV-VV
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 13:38:03 -0500
Received: from cantor2.suse.de ([195.135.220.15]:50720 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TwGpF-0005OQ-PE
	for qemu-devel@nongnu.org; Fri, 18 Jan 2013 13:38:01 -0500
Message-ID: <50F99684.3070700@suse.de>
Date: Fri, 18 Jan 2013 19:37:56 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1358532742-23156-1-git-send-email-agraf@suse.de>
	<1358532742-23156-3-git-send-email-agraf@suse.de>
In-Reply-To: <1358532742-23156-3-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate
 device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, qemu-devel@nongnu.org, =?ISO-8859-15?Q?Aur=E9lien_J?= =?ISO-8859-15?Q?arno?= <aurelien@aurel32.net>

Am 18.01.2013 19:12, schrieb Alexander Graf:
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> new file mode 100644
> index 0000000..7cbbf99
> --- /dev/null
> +++ b/hw/s390x/ipl.c
[...]
> +static TypeInfo s390_ipl_info =3D {

This should probably be static const - my tree-wide cleanup didn't catch
s390-next obviously. Please follow-up with a fix to avoid this being copi=
ed.

Similar issue could exist for ppc-next, please check.

Andreas

> +    .class_init =3D s390_ipl_class_init,
> +    .parent =3D TYPE_SYS_BUS_DEVICE,
> +    .name  =3D "s390-ipl",
> +    .instance_size  =3D sizeof(S390IPLState),
> +};
> +
> +static void s390_ipl_register_types(void)
> +{
> +    type_register_static(&s390_ipl_info);
> +}
> +
> +type_init(s390_ipl_register_types)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg