From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwIML-0005em-9u for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:16:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwIMJ-00054F-3U for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:16:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwIMI-000549-S3 for qemu-devel@nongnu.org; Fri, 18 Jan 2013 15:16:15 -0500 Message-ID: <50F9A9DC.2000905@redhat.com> Date: Fri, 18 Jan 2013 13:00:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358537372-27320-1-git-send-email-lcapitulino@redhat.com> <1358537372-27320-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1358537372-27320-4-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2ARKITNKXAACOEFDNAIST" Subject: Re: [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, dietmar@proxmox.com, agl@us.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ARKITNKXAACOEFDNAIST Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > docs/virtio-balloon-stats.txt | 102 ++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 docs/virtio-balloon-stats.txt >=20 > + > + o A key named 'stats', containing all avaiable stats. If the guest s/avaiable/available/ > + doesn't support a particular stat, its value will be -1. Currently= , > + the following stats are supported: > + > + - stat-swap-in > + - stat-swap-out > + - stat-major-faults > + - stat-minor-faults > + - stat-free-memory > + - stat-total-memory > + > + o A key named last-update, which contains the last stats update > + timestamp in seconds Is it worth mentioning that this is a timestamp relative to the Unix epoch? For that matter, does it even matter what the timestamp is relative to, or just that it increases when a new poll completes? Is it worth mentioning that the timestamp is computed by the host (that is, a broken guest can't fake the timestamp, even if it can provide bogus data for all the stats)? > + > + - As noted above, if a guest doesn't support a particular stat it > + will always be -1. However, it's also possible that a guest couldn'= t > + temporarily update one or even all stats. If this happens, just wai= t s/couldn't temporarily/temporarily couldn't/ > + > +Here are a few examples. The virtio-balloon device is assumed to be in= the > +'/machine/peripheral-anon/device[1]' QOM path. Is this QOM path stable, or can it change depending on target architecture and/or command-line arguments used to install the guest? It might be worth showing which command line arguments set up this particular QOM path. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2ARKITNKXAACOEFDNAIST Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ+ancAAoJEKeha0olJ0NqfHYH/3dDBCcaOh7p6oRnVf6Q0NXu pAaTp3uZSWB5iPmxuBFu9lD1P/sw9OyMCc5d7/fdpFgROg0OcminKxuGGNtKp9UN lKcOjYFrStA0SVX3Iee+VoFyXdGnRxtBWOD45N/OjlLz73boczlK3R06lGGLoNma ROb4cHAIdkKayLw0RhOe7KGq9mH11DbpZ4ye7Ywx2QHxrd0SQys49ns+Jp7QQGTz ZCGdp0HtxErbEasJS1UuAewiXSlR3le756/TsNK5q8Zb74+9BkuBiNTKNo7x+iwK EFEvqITPQWwXeueucn6Ohg7nZdJK9Xspw9o7L7/p6vDQPZ4aVCKM8sL295kDB7M= =RaI0 -----END PGP SIGNATURE----- ------enig2ARKITNKXAACOEFDNAIST--