From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwMxX-0001bJ-CY for qemu-devel@nongnu.org; Fri, 18 Jan 2013 20:11:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwMxW-0004yY-98 for qemu-devel@nongnu.org; Fri, 18 Jan 2013 20:10:59 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:48038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwMxW-0004yQ-2S for qemu-devel@nongnu.org; Fri, 18 Jan 2013 20:10:58 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 Jan 2013 18:10:55 -0700 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id DA4413E40042 for ; Fri, 18 Jan 2013 18:10:47 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0J1Arnd294426 for ; Fri, 18 Jan 2013 18:10:53 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0J1Ao9M003830 for ; Fri, 18 Jan 2013 18:10:52 -0700 Message-ID: <50F9EEED.5020702@linux.vnet.ibm.com> Date: Fri, 18 Jan 2013 19:55:09 -0500 From: Stefan Berger MIME-Version: 1.0 References: <1358524968-22297-1-git-send-email-stefanb@linux.vnet.ibm.com> <1358524968-22297-9-git-send-email-stefanb@linux.vnet.ibm.com> <50F991FE.3000901@redhat.com> <50F9E580.2000602@linux.vnet.ibm.com> In-Reply-To: <50F9E580.2000602@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V20 8/8] Add fd parameter for TPM passthrough driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: mst@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, andreas.niederl@iaik.tugraz.at On 01/18/2013 07:14 PM, Stefan Berger wrote: > On 01/18/2013 01:18 PM, Eric Blake wrote: >> On 01/18/2013 09:02 AM, Stefan Berger wrote: > When libvirt forks, the child process inherits the file descriptors, > among them those of the taps and /dev/tpm0. The subsequent execve > keeps the file descriptor open. QEMU then reads the TPM file > descriptor from the command line into above TPMInfo->fd. This also > works with 'exec 100<>/dev/tpm0' via command line. > Similar to the SELinux labeling of all the other file descriptors I > also use the one for the TPM device for SELinux labeling. > I have to correct this: The libvirt patches for this use path= on the command line and also apply the SELinux label on the path rather than the fd. So, this patch then adds file descriptor passing support to have equivalent functionality to other devices. Regards, Stefan