From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwVU8-0000qy-Sl for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:17:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwVU8-00008F-01 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:17:12 -0500 Received: from mail-ea0-f178.google.com ([209.85.215.178]:52308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwVU7-000086-Q2 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:17:11 -0500 Received: by mail-ea0-f178.google.com with SMTP id a14so1831369eaa.23 for ; Sat, 19 Jan 2013 02:17:10 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50FA72A2.9060303@redhat.com> Date: Sat, 19 Jan 2013 11:17:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358012138-21613-1-git-send-email-pbonzini@redhat.com> <50F98E8E.6010807@web.de> In-Reply-To: <50F98E8E.6010807@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Blue Swirl , qemu-devel@nongnu.org Il 18/01/2013 19:03, Andreas Färber ha scritto: > I believe this broke bsd-user: util/oslib-posix.c has qemu_vmalloc() > guarded with > #if !defined(CONFIG_BSD_USER) > which now no longer shields it from the qemu_vmalloc() reimplementation > in bsd-user/mmap.c. > > Any suggestion how to fix? Does the function really needs to be called qemu_vmalloc? If not, having the same name for two different things is bad. Paolo