From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwVtk-00024a-MR for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:43:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwVtj-0006TM-Lb for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:43:40 -0500 Received: from mail-ea0-f182.google.com ([209.85.215.182]:47419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwVtj-0006TB-EC for qemu-devel@nongnu.org; Sat, 19 Jan 2013 05:43:39 -0500 Received: by mail-ea0-f182.google.com with SMTP id a12so1760120eaa.27 for ; Sat, 19 Jan 2013 02:43:38 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50FA78D6.4060202@redhat.com> Date: Sat, 19 Jan 2013 11:43:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358012138-21613-1-git-send-email-pbonzini@redhat.com> <50F98E8E.6010807@web.de> <50FA72A2.9060303@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Il 19/01/2013 11:21, Blue Swirl ha scritto: >> > Does the function really needs to be called qemu_vmalloc? If not, >> > having the same name for two different things is bad. > I've just sent a patch to fix this. > > But new code could be introduced that used qemu_vmalloc() so I'm not > sure this approach is the best. Right now there isn't even a matching qemu_vfree(); the implementation in util/oslib-posix.c would be used and that would use free() instead of munmap(). So, code that happened to use qemu_vmalloc() outside bsd-user would be completely wrong. It was a time bomb, and it's a good thing that it was exposed. Paolo