From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, Eduardo Otubo <otubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] link seccomp only with softmmu targets
Date: Sat, 19 Jan 2013 16:31:13 +0100 [thread overview]
Message-ID: <50FABC41.3040605@redhat.com> (raw)
In-Reply-To: <50FAB5F6.4020502@msgid.tls.msk.ru>
Il 19/01/2013 16:04, Michael Tokarev ha scritto:
>
>> Now, if seccomp is detected, it is linked into every executable,
>> but is used only by softmmu targets (from vl.c). So link it
>> only where it is actually needed.
>
> Note this is not just a cleanup. For some reason, at least
> debian package of seccomp lacks static library (this needs
> separate investigation and maybe a fix), so when building
> linux-user-static targets the build fails, since libseccomp
> is linked into static linux-user executables.
>
> So consider it is a bugfix.
Ack.
> Note that Makefile.objs adds qemu-seccomp.o to common-objs-y, --
> maybe this whole variable (common-objs) should be renamed
> to softmmu-objs, to match other softmmu-* stuff? But I'm
> not sure I understand this makefile machinery.
I'm going to unify common-obj-y/universal-obj-y/user-obj-y (see patches
from today) so that common-obj-y just means "built in the toplevel
directory for the target directories".
All of libs_softmmu etc. should probably be moved to the Makefiles as well.
Paolo
next prev parent reply other threads:[~2013-01-19 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 14:58 [Qemu-devel] [PATCH] link seccomp only with softmmu targets Michael Tokarev
2013-01-19 15:04 ` Michael Tokarev
2013-01-19 15:31 ` Paolo Bonzini [this message]
2013-01-19 22:33 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FABC41.3040605@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=otubo@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).