From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwaO6-0006ko-Sg for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:31:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwaO5-0005zt-Pz for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:31:18 -0500 Received: from mail-ea0-f173.google.com ([209.85.215.173]:36019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwaO5-0005zk-JF for qemu-devel@nongnu.org; Sat, 19 Jan 2013 10:31:17 -0500 Received: by mail-ea0-f173.google.com with SMTP id i1so1412723eaa.18 for ; Sat, 19 Jan 2013 07:31:16 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50FABC41.3040605@redhat.com> Date: Sat, 19 Jan 2013 16:31:13 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358607489-12478-1-git-send-email-mjt@msgid.tls.msk.ru> <50FAB5F6.4020502@msgid.tls.msk.ru> In-Reply-To: <50FAB5F6.4020502@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] link seccomp only with softmmu targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org, Eduardo Otubo Il 19/01/2013 16:04, Michael Tokarev ha scritto: > >> Now, if seccomp is detected, it is linked into every executable, >> but is used only by softmmu targets (from vl.c). So link it >> only where it is actually needed. > > Note this is not just a cleanup. For some reason, at least > debian package of seccomp lacks static library (this needs > separate investigation and maybe a fix), so when building > linux-user-static targets the build fails, since libseccomp > is linked into static linux-user executables. > > So consider it is a bugfix. Ack. > Note that Makefile.objs adds qemu-seccomp.o to common-objs-y, -- > maybe this whole variable (common-objs) should be renamed > to softmmu-objs, to match other softmmu-* stuff? But I'm > not sure I understand this makefile machinery. I'm going to unify common-obj-y/universal-obj-y/user-obj-y (see patches from today) so that common-obj-y just means "built in the toplevel directory for the target directories". All of libs_softmmu etc. should probably be moved to the Makefiles as well. Paolo