From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwcoF-0008Pr-B3 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:06:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwcoE-0002tM-6G for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:06:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56783 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwcoD-0002le-S4 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 13:06:26 -0500 Message-ID: <50FAE072.4000904@suse.de> Date: Sat, 19 Jan 2013 19:05:38 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1358590008-1681-1-git-send-email-pbonzini@redhat.com> <1358590008-1681-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1358590008-1681-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/4] build: move around libcacard-y definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org Am 19.01.2013 11:06, schrieb Paolo Bonzini: > It is also needed if !CONFIG_SOFTMMU, unlike everything that surrounds = it. Why? linux-user should not depend on it - bad wording only? Andreas > Signed-off-by: Paolo Bonzini > --- > Makefile.objs | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/Makefile.objs b/Makefile.objs > index d465a72..3548f9b 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -34,6 +34,15 @@ CONFIG_REALLY_VIRTFS=3Dy > endif > =20 > ###################################################################### > +# smartcard > + > +libcacard-y +=3D libcacard/cac.o libcacard/event.o > +libcacard-y +=3D libcacard/vcard.o libcacard/vreader.o > +libcacard-y +=3D libcacard/vcard_emul_nss.o > +libcacard-y +=3D libcacard/vcard_emul_type.o > +libcacard-y +=3D libcacard/card_7816.o > + > +###################################################################### > # Target independent part of system emulation. The long term path is t= o > # suppress *all* target specific code in case of system emulation, i.e= . a > # single QEMU executable should support all CPUs and machines. > @@ -77,15 +86,6 @@ ifeq ($(CONFIG_SECCOMP),y) > common-obj-y +=3D qemu-seccomp.o > endif > =20 > -###################################################################### > -# smartcard > - > -libcacard-y +=3D libcacard/cac.o libcacard/event.o > -libcacard-y +=3D libcacard/vcard.o libcacard/vreader.o > -libcacard-y +=3D libcacard/vcard_emul_nss.o > -libcacard-y +=3D libcacard/vcard_emul_type.o > -libcacard-y +=3D libcacard/card_7816.o > - > common-obj-$(CONFIG_SMARTCARD_NSS) +=3D $(libcacard-y) > =20 > ###################################################################### >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg