From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more
Date: Sat, 19 Jan 2013 23:06:16 +0100 [thread overview]
Message-ID: <50FB18D8.7010805@redhat.com> (raw)
In-Reply-To: <50FAE1E3.6010309@suse.de>
Il 19/01/2013 19:11, Andreas Färber ha scritto:
>> > The patches are mostly mechanical substitutions, and there is no
>> > user-visible change---neither in total build time, nor in the files that
>> > are linked into the executables.
> Without having tested this yet I want to remind that it is necessary for
> qom/cpu.c to be built twice
Hmm, it's not anymore actually (since libuser was removed). It hasn't
been built twice for a month and apparently nothing broke.
> , to not run into similar issues like
> util/oslib-posix.c.
The only dependency is
#if !defined(CONFIG_USER_ONLY)
int kvm_fd;
bool kvm_vcpu_dirty;
#endif
struct KVMState *kvm_state;
struct kvm_run *kvm_run;
Plenty of other fields are meaningless for !CONFIG_USER_ONLY but are
unconditionally present in struct CPUState. Given this inconsistency,
why is it still useful to build it twice?
Paolo
next prev parent reply other threads:[~2013-01-19 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 10:06 [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more Paolo Bonzini
2013-01-19 10:06 ` [Qemu-devel] [PATCH 1/4] build: move around libcacard-y definition Paolo Bonzini
2013-01-19 18:05 ` Andreas Färber
2013-01-19 22:01 ` Paolo Bonzini
2013-01-19 23:26 ` Andreas Färber
2013-01-19 10:06 ` [Qemu-devel] [PATCH 2/4] build: use -$(CONFIG_SECCOMP) instead of ifeq Paolo Bonzini
2013-01-19 18:06 ` Andreas Färber
2013-01-19 10:06 ` [Qemu-devel] [PATCH 3/4] build: remove universal-obj-y Paolo Bonzini
2013-01-19 10:06 ` [Qemu-devel] [PATCH 4/4] build: remove extra-obj-y Paolo Bonzini
2013-01-19 18:11 ` [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more Andreas Färber
2013-01-19 22:06 ` Paolo Bonzini [this message]
2013-01-19 22:07 ` Paolo Bonzini
2013-01-19 23:22 ` Andreas Färber
2013-01-20 9:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FB18D8.7010805@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).