From: "Andreas Färber" <afaerber@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation
Date: Sun, 20 Jan 2013 18:29:25 +0100 [thread overview]
Message-ID: <50FC2975.80601@suse.de> (raw)
In-Reply-To: <1358634492-22627-2-git-send-email-grant.likely@secretlab.ca>
Am 19.01.2013 23:28, schrieb Grant Likely:
> The etraxfs Ethernet model implements quite a nice bitbanging core. The
> change splits it out into a separate .c file. There are no functional
> changes here, just movement of code and reformatting to match qemu
> coding standards.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Paul Brook <paul@codesourcery.com>
> Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> hw/bitbang_mdio.c | 263 +++++++++++++++++++++++++++++++++++++++++++++++
> hw/bitbang_mdio.h | 72 +++++++++++++
> hw/cris/Makefile.objs | 1 +
> hw/etraxfs_eth.c | 273 +------------------------------------------------
> 4 files changed, 337 insertions(+), 272 deletions(-)
> create mode 100644 hw/bitbang_mdio.c
> create mode 100644 hw/bitbang_mdio.h
If you fix coding style issues in the original file first this helps
git's copy detection. Looks like either you have it disabled for patches
or it's not detecting it at all... I would expect some "similarity N%"
notice.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-20 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 22:28 [Qemu-devel] [PATCH 0/3] Generalize bitbang MDIO and use for versatile-pb Grant Likely
2013-01-19 22:28 ` [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation Grant Likely
2013-01-20 17:29 ` Andreas Färber [this message]
2013-01-21 12:51 ` Edgar E. Iglesias
2013-01-19 22:28 ` [Qemu-devel] [PATCH 2/3] net/bitbang_mdio: Never set PHY RST and ANEG_RST bits on register write Grant Likely
2013-01-19 22:28 ` [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc91c111 network device Grant Likely
2013-01-20 11:29 ` Peter Maydell
2013-01-21 13:12 ` Grant Likely
2013-01-20 17:26 ` [Qemu-devel] [PATCH 0/3] Generalize bitbang MDIO and use for versatile-pb Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC2975.80601@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=edgar.iglesias@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).