From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twyi4-0000Xv-Ko for qemu-devel@nongnu.org; Sun, 20 Jan 2013 12:29:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Twyi3-000416-DG for qemu-devel@nongnu.org; Sun, 20 Jan 2013 12:29:32 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33785 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twyi3-000412-6q for qemu-devel@nongnu.org; Sun, 20 Jan 2013 12:29:31 -0500 Message-ID: <50FC2975.80601@suse.de> Date: Sun, 20 Jan 2013 18:29:25 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1358634492-22627-1-git-send-email-grant.likely@secretlab.ca> <1358634492-22627-2-git-send-email-grant.likely@secretlab.ca> In-Reply-To: <1358634492-22627-2-git-send-email-grant.likely@secretlab.ca> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Grant Likely Cc: Peter Maydell , Anthony Liguori , "Edgar E. Iglesias" , qemu-devel@nongnu.org, Paul Brook Am 19.01.2013 23:28, schrieb Grant Likely: > The etraxfs Ethernet model implements quite a nice bitbanging core. The > change splits it out into a separate .c file. There are no functional > changes here, just movement of code and reformatting to match qemu > coding standards. >=20 > Cc: Peter Maydell > Cc: Paul Brook > Cc: Edgar E. Iglesias > Cc: Anthony Liguori > Signed-off-by: Grant Likely > --- > hw/bitbang_mdio.c | 263 +++++++++++++++++++++++++++++++++++++++++= ++++++ > hw/bitbang_mdio.h | 72 +++++++++++++ > hw/cris/Makefile.objs | 1 + > hw/etraxfs_eth.c | 273 +----------------------------------------= -------- > 4 files changed, 337 insertions(+), 272 deletions(-) > create mode 100644 hw/bitbang_mdio.c > create mode 100644 hw/bitbang_mdio.h If you fix coding style issues in the original file first this helps git's copy detection. Looks like either you have it disabled for patches or it's not detecting it at all... I would expect some "similarity N%" notice. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg