From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwzSe-0003cv-UU for qemu-devel@nongnu.org; Sun, 20 Jan 2013 13:17:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwzSd-00077u-Uz for qemu-devel@nongnu.org; Sun, 20 Jan 2013 13:17:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34774 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwzSd-00070t-O3 for qemu-devel@nongnu.org; Sun, 20 Jan 2013 13:17:39 -0500 Message-ID: <50FC3497.9090606@suse.de> Date: Sun, 20 Jan 2013 19:16:55 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1358704579-15210-1-git-send-email-afaerber@suse.de> In-Reply-To: <1358704579-15210-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.4?] isa: QOM'ify isa_bus_from_device() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel Am 20.01.2013 18:56, schrieb Andreas F=C3=A4rber: > DeviceState::parent_bus is document as private and should be accessed "documented" - please fix when applying. > through qdev_get_parent_bus(). Use a DEVICE() cast instead of accessing > ISADevice's qdev field directly. Use ISA_BUS() in place of DO_UPCAST(). >=20 > Signed-off-by: Andreas F=C3=A4rber > Cc: Anthony Liguori > --- > hw/isa.h | 2 +- > 1 Datei ge=C3=A4ndert, 1 Zeile hinzugef=C3=BCgt(+), 1 Zeile entfernt(-= ) >=20 > diff --git a/hw/isa.h b/hw/isa.h > index 62e89d3..7a8874a 100644 > --- a/hw/isa.h > +++ b/hw/isa.h > @@ -82,7 +82,7 @@ void isa_register_portio_list(ISADevice *dev, uint16_= t start, > =20 > static inline ISABus *isa_bus_from_device(ISADevice *d) > { > - return DO_UPCAST(ISABus, qbus, d->qdev.parent_bus); > + return ISA_BUS(qdev_get_parent_bus(DEVICE(d))); > } > =20 > extern hwaddr isa_mem_base; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg