From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxCuU-00067N-Ds for qemu-devel@nongnu.org; Mon, 21 Jan 2013 03:39:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxCuR-0002bW-Ed for qemu-devel@nongnu.org; Mon, 21 Jan 2013 03:39:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52917 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxCuR-0002b9-8d for qemu-devel@nongnu.org; Mon, 21 Jan 2013 03:39:15 -0500 Message-ID: <50FCFEAB.5000600@suse.de> Date: Mon, 21 Jan 2013 09:39:07 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1358435794-8406-1-git-send-email-imammedo@redhat.com> <1358435794-8406-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1358435794-8406-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Anthony Liguori , ehabkost@redhat.com Am 17.01.2013 16:16, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > --- > target-i386/cpu.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 333745b..ce914da 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1399,6 +1399,8 @@ static int cpu_x86_parse_featurestr(x86_def_t *x8= 6_cpu_def, char *features) > goto error; > } > if (numvalue < 0x80000000) { > + fprintf(stderr, "xlevel value shall always be >=3D= 0x80000000" > + ", fixup will be deprecated in future vers= ions\n"); > numvalue +=3D 0x80000000; > } > x86_cpu_def->xlevel =3D numvalue; This has been reviewed without objections so far, so I would apply it for 1.4. Either way you should document this intent for users already: http://wiki.qemu.org/ChangeLog/1.4 We had such discussions before, around removing cpudef support. When do you plan to remove this, and being deprecated, shouldn't it rather read "fixup will be removed in future versions"? ;) If it fits within 80 chars I can edit it myself. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg