From: Paolo Bonzini <pbonzini@redhat.com>
To: luoyonggang@gmail.com
Cc: qemu-level <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH] meson: rewrite curses/iconv test
Date: Tue, 20 Oct 2020 11:12:36 +0200 [thread overview]
Message-ID: <50c8ae90-4eb3-0025-e177-eba51e51c9aa@redhat.com> (raw)
In-Reply-To: <CAE2XoE9YRWK64D8w605cwmp+bdNRMYui25mx677pLBmFxxaqXQ@mail.gmail.com>
On 19/10/20 21:58, 罗勇刚(Yonggang Luo) wrote:
>
>> + if not curses.found() + curses_compile_args =
>> ['-DNCURSES_WIDECHAR']
>
> Here is what I think need improve in meson, when declare
> dependencies, we need a extra option compile_args for easily testing
> extra compile args, and maybe also need link_args, and after suceed,
> these flags should as a part of the dependencies.
I think it would make sense if cc.find_library had extra arguments that
would be added to the dependency and, in case of compile_args, to the
has_headers check. It's a tradeoff between keeping the language simple
and making the users' code smaller.
Another possible extension is for cc.links to allow internal
dependencies, as long as they do not depend on sources.
Paolo
prev parent reply other threads:[~2020-10-20 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 9:45 [PATCH] meson: rewrite curses/iconv test Paolo Bonzini
2020-10-19 19:58 ` 罗勇刚(Yonggang Luo)
2020-10-20 9:12 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50c8ae90-4eb3-0025-e177-eba51e51c9aa@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).