From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>
Cc: qemu-s390x@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init()
Date: Fri, 20 Oct 2023 15:16:36 +0200 [thread overview]
Message-ID: <50d1cf1a-820e-4a02-9357-6be77d448cdd@redhat.com> (raw)
In-Reply-To: <20231020125728.579747-1-thuth@redhat.com>
On 20.10.23 14:57, Thomas Huth wrote:
> We must not call register_savevm_live() during instance_init()
> since instances can be created at any time, e.g. during introspection
> of a device. We must register the savevm handler during realize()
> instead. Fix it now in the s390x devices.
>
> Thomas Huth (3):
> hw/s390x/s390-skeys: Don't call register_savevm_live() during
> instance_init()
> hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled"
> property
> hw/s390x/s390-stattrib: Don't call register_savevm_live() during
> instance_init()
>
> hw/s390x/s390-skeys.c | 35 ++++++--------------------
> hw/s390x/s390-stattrib.c | 54 +++++++++++++++-------------------------
> 2 files changed, 28 insertions(+), 61 deletions(-)
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-10-20 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 12:57 [PATCH 0/3] hw/s390x: Don't call register_savevm_live() during instance_init() Thomas Huth
2023-10-20 12:57 ` [PATCH 1/3] hw/s390x/s390-skeys: " Thomas Huth
2023-10-20 12:57 ` [PATCH 2/3] hw/s390x/s390-stattrib: Simplify handling of the "migration-enabled" property Thomas Huth
2023-10-20 12:57 ` [PATCH 3/3] hw/s390x/s390-stattrib: Don't call register_savevm_live() during instance_init() Thomas Huth
2023-10-20 13:27 ` Thomas Huth
2023-10-20 13:16 ` David Hildenbrand [this message]
2023-10-20 14:05 ` [PATCH 0/3] hw/s390x: " Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50d1cf1a-820e-4a02-9357-6be77d448cdd@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).