Re: [Qemu-devel] [RFC PATCH v4 26/44] kconfig: introduce kconfig files

[Thomas Huth <thuth@redhat.com>]

On 2019-01-23 07:56, Yang Zhong wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> The Kconfig files were generated mostly with this script:
> 
>   for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do
>     set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' `
>     shift
>     if test $# = 1; then
>       cat >> $(dirname $1)/Kconfig << EOF
> config ${i#CONFIG_}
>     bool
> 
> EOF
>       git add $(dirname $1)/Kconfig
>     else
>       echo $i $*
>     fi
>   done
>   sed -i '$d' hw/*/Kconfig
>   for i in hw/*; do
>     if test -d $i && ! test -f $i/Kconfig; then
>       touch $i/Kconfig
>       git add $i/Kconfig
>     fi
>   done
> 
> Whenever a symbol is referenced from multiple subdirectories, the
> script prints the list of directories that reference the symbol.
> These symbols have to be added manually to the Kconfig files.
> 
> Kconfig.host and hw/Kconfig were created manually.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
[...]
> diff --git a/hw/cris/Kconfig b/hw/cris/Kconfig
> new file mode 100644
> index 0000000000..c2c26e5150
> --- /dev/null
> +++ b/hw/cris/Kconfig
> @@ -0,0 +1,2 @@
> +config AXIS
> +    bool

Please also add here:

config ETRAXFS
    bool

> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> new file mode 100644
> index 0000000000..1a3e8b0e02
> --- /dev/null
> +++ b/hw/riscv/Kconfig
> @@ -0,0 +1,14 @@
> +config HTIF
> +    bool
> +
> +config HART
> +    bool
> +
> +config SIFIVE
> +    bool
> +
> +config SPIKE
> +    bool
> +
> +config RISCV_VIRTIO
> +    bool

Please rename the RISCV_VIRTIO to RISCV_VIRT.

We also additionally need these two here:

config SIFIVE_E
    bool

config SIFIVE_U
    bool

 Thanks,
  Thomas