qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: stefanha@gmaiDDDl.com, yangxiaojuan@loongson.cn, maobibo@loongson.cn
Subject: Re: [PATCH 1/1] target/loongarch: Fix loongarch fdt addr confict
Date: Wed, 9 Nov 2022 00:09:58 +1100	[thread overview]
Message-ID: <50ebdf82-740e-f239-7e2b-162a22b758fc@linaro.org> (raw)
In-Reply-To: <20221108130204.926434-1-gaosong@loongson.cn>

On 11/9/22 00:02, Song Gao wrote:
> Fix LoongArch check-tcg error:
>    TEST    hello on loongarch64
> qemu-system-loongarch64: Some ROM regions are overlapping
> These ROM regions might have been loaded by direct user request or by default.
> They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded into guest memory.
> Check whether you intended to load all this guest code, and whether it has been built to load to the correct addresses.
> 
> The following two regions overlap (in the memory address space):
>    hello ELF program header segment 0 (addresses 0x0000000000200000 - 0x0000000000242000)
>    fdt (addresses 0x0000000000200000 - 0x0000000000300000)
> make[1]: *** [Makefile:177: run-hello] Error 1
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   tests/tcg/loongarch64/system/kernel.ld |  7 +++++--
>   1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/tcg/loongarch64/system/kernel.ld b/tests/tcg/loongarch64/system/kernel.ld
> index f1a7c0168c..2110cfe8be 100644
> --- a/tests/tcg/loongarch64/system/kernel.ld
> +++ b/tests/tcg/loongarch64/system/kernel.ld
> @@ -2,8 +2,11 @@ ENTRY(_start)
>   
>   SECTIONS
>   {
> -    /* Linux kernel legacy start address.  */
> -    . = 0x9000000000200000;
> +    /*
> +     * Linux kernel legacy start address.
> +     * FDT is load at 0x200000, kernel image size must be smaller than 1M
> +     */
> +    . = 0x100000;

Or start above the fdt at 3M, to avoid that limitation?
The comment about the Linux kernel start address no longer applies.

Either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


      reply	other threads:[~2022-11-08 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08 13:02 [PATCH 1/1] target/loongarch: Fix loongarch fdt addr confict Song Gao
2022-11-08 13:09 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ebdf82-740e-f239-7e2b-162a22b758fc@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=maobibo@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmaiDDDl.com \
    --cc=yangxiaojuan@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).