From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byeya-0002h7-0k for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:07:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byeyW-0002B2-QP for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:07:39 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:32874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byeyW-0002AW-Jh for qemu-devel@nongnu.org; Mon, 24 Oct 2016 09:07:36 -0400 Received: by mail-wm0-x242.google.com with SMTP id d128so9768305wmf.0 for ; Mon, 24 Oct 2016 06:07:36 -0700 (PDT) Sender: Paolo Bonzini References: <20161020103636.22228-1-dgilbert@redhat.com> <87y41dewcz.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: <50ee0fea-44e6-cc0f-f090-4c6410fbf37e@redhat.com> Date: Mon, 24 Oct 2016 15:07:31 +0200 MIME-Version: 1.0 In-Reply-To: <87y41dewcz.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org On 24/10/2016 14:59, Markus Armbruster wrote: > "Dr. David Alan Gilbert (git)" writes: > >> From: "Dr. David Alan Gilbert" >> >> In a1771070e7 I added an error message during migration loading >> so you could see the field that failed to load. >> Unfortunately this triggers during the expected-failure case >> testing in tests/test-vmstate. >> >> This silences that error by providing a dummy monitor pointer >> that doesn't output anything and then selecting it around >> the noisy part of the test. >> >> (I couldn't find anywhere better than libqtest.h for the declaration >> but stubs doesn't have it's own header; is it worth creating one >> just for that?) > > Maybe. Always hard to say for the first one. > > You could simply put it in monitor.h. When somebody uses it outside > tests, linking fails. If that bothers you, feel free to implement a > silent non-stub monitor. > > With Eric's spelling fixes squashed in, and with or without my > suggestion on PATCH 2: > Reviewed-by: Markus Armbruster We could also implement error_vprintf so that it calls g_test_message(). That would improve the logging. Paolo