Re: [Qemu-devel] [PATCH] iotests: Make 182 do without device_add

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On 17.04.19 17:30, Max Reitz wrote:
> 182 fails if qemu has no support for hotplugging of a virtio-blk device.
> Using an NBD server instead works just as well for the test, even on
> qemus without hotplugging support.
> 
> Fixes: 6d0a4a0fb5c8f10c8eb68b52cfda0082b00ae963
> Reported-by: Danilo C. L. de Paula <ddepaula@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> To reintroduce the bug for which this test was written, revert the
> following commits:
> 
> $ git revert -n \
>     23dece19da41724349809873923e20a48b619cb7 \
>     6ceabe6f77e4ae5ac2fa3d2ac1be11dc95021941 \
>     a6aeca0ca530f104b5a5dd6704fca22b2c5edefa \
>     577a133988c76e4ebf01d050d0d758d207a1baf7
> ---
>  tests/qemu-iotests/182     | 22 +++++++++++++++++-----
>  tests/qemu-iotests/182.out |  1 +
>  2 files changed, 18 insertions(+), 5 deletions(-)

Thanks for the reviews, applied to my block branch.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]