qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Denys Zagorui <dzagorui@cisco.com>, hpa@zytor.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] KVM serial8250: too much work for irq3
Date: Fri, 11 Jan 2019 00:44:54 +0100	[thread overview]
Message-ID: <51071cba-c18f-e491-4d92-6a40130584a7@redhat.com> (raw)
In-Reply-To: <8e67afb3-46b4-9d04-552f-740331165f8f@cisco.com>

On 22/09/17 15:28, Denys Zagorui wrote:
> Hello
> 
> This is known issue, it was mentioned at first time about 9 years ago.
> 
> https://lkml.org/lkml/2008/2/5/401
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=986761

The issue is simply that QEMU disregards the baud rate that the guest
programs into the serial port.  H. Peter Anvin's patch, which you
mention, is only a band aid that is geared specifically at avoiding
Linux's error.

It was fixed for real in commit 6936bfe514bbac7af4b24fad9ed9688b78b5be69
by implementing a baud rate timer (May 2008), but then undone in
fcfb4d6aae611d1f804d486d3c998000912c4c81 (March 2013) when the serial
port got flow control support.

Part of the reason may have been laziness, but also there are reasons to
keep it this way.  Basically, the baud rate timer was implemented also
in order to mitigate the problem with losing characters sent by the
guest on the serial console; and thanks to flow control, QEMU will
already slow down the transmit so that the other side never loses
characters.  And because looking at logs on a serial console bps is slow
and mildly annoying even at 115200 bps, it was decided that the "too
much work" error was the lesser evil.

Thanks,

Paolo

  reply	other threads:[~2019-01-10 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 13:28 [Qemu-devel] KVM serial8250: too much work for irq3 Denys Zagorui
2019-01-10 23:44 ` Paolo Bonzini [this message]
2019-01-11  0:04   ` hpa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51071cba-c18f-e491-4d92-6a40130584a7@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dzagorui@cisco.com \
    --cc=hpa@zytor.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).