From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41446)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1CZl-0003fH-6l
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 04:06:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1CZk-0003JO-0e
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 04:06:25 -0500
Received: from cantor2.suse.de ([195.135.220.15]:46944 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1CZj-0003JK-QQ
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 04:06:23 -0500
Message-ID: <510B8585.2060602@suse.de>
Date: Fri, 01 Feb 2013 10:06:13 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1358704579-15210-1-git-send-email-afaerber@suse.de>
	<50FC3497.9090606@suse.de>
In-Reply-To: <50FC3497.9090606@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.4?] isa: QOM'ify isa_bus_from_device()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 20.01.2013 19:16, schrieb Andreas F=C3=A4rber:
> Am 20.01.2013 18:56, schrieb Andreas F=C3=A4rber:
>> DeviceState::parent_bus is document as private and should be accessed
>=20
> "documented" - please fix when applying.
>=20
>> through qdev_get_parent_bus(). Use a DEVICE() cast instead of accessin=
g
>> ISADevice's qdev field directly. Use ISA_BUS() in place of DO_UPCAST()=
.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>> ---
>>  hw/isa.h |    2 +-
>>  1 Datei ge=C3=A4ndert, 1 Zeile hinzugef=C3=BCgt(+), 1 Zeile entfernt(=
-)

Ping? Not 1.4 material or an oversight? Should I resend due to typo?

Andreas

>> diff --git a/hw/isa.h b/hw/isa.h
>> index 62e89d3..7a8874a 100644
>> --- a/hw/isa.h
>> +++ b/hw/isa.h
>> @@ -82,7 +82,7 @@ void isa_register_portio_list(ISADevice *dev, uint16=
_t start,
>> =20
>>  static inline ISABus *isa_bus_from_device(ISADevice *d)
>>  {
>> -    return DO_UPCAST(ISABus, qbus, d->qdev.parent_bus);
>> +    return ISA_BUS(qdev_get_parent_bus(DEVICE(d)));
>>  }
>> =20
>>  extern hwaddr isa_mem_base;

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg