From: Laszlo Ersek <lersek@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
lcapitulino@redhat.com, qemu-devel@nongnu.org,
fred.konrad@greensocs.com
Subject: Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error
Date: Fri, 01 Feb 2013 10:42:10 +0100 [thread overview]
Message-ID: <510B8DF2.9090201@redhat.com> (raw)
In-Reply-To: <CAFEAcA-XZ7fr6enpQuCP1rO6NUUhpUgKjmPKNOgDLoa2peQ=pA@mail.gmail.com>
On 01/31/13 19:24, Peter Maydell wrote:
> We should only be reporting one error:
> "we failed because you asked for this bus and it's full" should
> override the default "we failed to find this bus". We can fix
> that by having the recursion stop as soon as we get an error.
> I think the QMP caller should also only get one error.
> Why does the qmp user need to get QERR_BUS_NOT_FOUND?
> (it would be an incorrect error anyway in the case where
> we have the GENERIC_ERROR text, because we have in fact found
> the bus, we just couldn't use it.)
That's a good clear goal which I can stick to -- let the first /
innermost error (the one with the most specific human readable text
usually) prevail, no matter the client type.
Thanks!
Laszlo
parent reply other threads:[~2013-02-01 14:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAFEAcA-XZ7fr6enpQuCP1rO6NUUhpUgKjmPKNOgDLoa2peQ=pA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510B8DF2.9090201@redhat.com \
--to=lersek@redhat.com \
--cc=armbru@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).