* Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error
[not found] ` <CAFEAcA-XZ7fr6enpQuCP1rO6NUUhpUgKjmPKNOgDLoa2peQ=pA@mail.gmail.com>
@ 2013-02-01 9:42 ` Laszlo Ersek
0 siblings, 0 replies; only message in thread
From: Laszlo Ersek @ 2013-02-01 9:42 UTC (permalink / raw)
To: Peter Maydell; +Cc: Markus Armbruster, lcapitulino, qemu-devel, fred.konrad
On 01/31/13 19:24, Peter Maydell wrote:
> We should only be reporting one error:
> "we failed because you asked for this bus and it's full" should
> override the default "we failed to find this bus". We can fix
> that by having the recursion stop as soon as we get an error.
> I think the QMP caller should also only get one error.
> Why does the qmp user need to get QERR_BUS_NOT_FOUND?
> (it would be an incorrect error anyway in the case where
> we have the GENERIC_ERROR text, because we have in fact found
> the bus, we just couldn't use it.)
That's a good clear goal which I can stick to -- let the first /
innermost error (the one with the most specific human readable text
usually) prevail, no matter the client type.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-02-01 14:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <510A7683.2000303@greensocs.com>
[not found] ` <1359646945-2876-3-git-send-email-lersek@redhat.com>
[not found] ` <CAFEAcA-hmYqhgN5Jk76uOvXvyjakg3tfV4QWJ-9f8a0gByfgfg@mail.gmail.com>
[not found] ` <510A9642.90804@redhat.com>
[not found] ` <CAFEAcA-oZt5-RA2=0UrGaAH7+aawxJ1fmRkASvW7i+ZLF8covw@mail.gmail.com>
[not found] ` <510A9DA4.6050301@redhat.com>
[not found] ` <CAFEAcA8-y2bi3otzJ2sRfp7XjwXBBt8f96zVz=bQuZJmLPRp_A@mail.gmail.com>
[not found] ` <510AB59D.9000800@redhat.com>
[not found] ` <CAFEAcA-XZ7fr6enpQuCP1rO6NUUhpUgKjmPKNOgDLoa2peQ=pA@mail.gmail.com>
2013-02-01 9:42 ` [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).