From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1HG4-0006bT-5X for qemu-devel@nongnu.org; Fri, 01 Feb 2013 09:06:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1HG1-0001Xz-ON for qemu-devel@nongnu.org; Fri, 01 Feb 2013 09:06:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1D6k-0003YO-P3 for qemu-devel@nongnu.org; Fri, 01 Feb 2013 04:40:30 -0500 Message-ID: <510B8DF2.9090201@redhat.com> Date: Fri, 01 Feb 2013 10:42:10 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <510A7683.2000303@greensocs.com> <1359646945-2876-3-git-send-email-lersek@redhat.com> <510A9642.90804@redhat.com> <510A9DA4.6050301@redhat.com> <510AB59D.9000800@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 2/2] qbus_find_recursive(): the "free slots" constraint needs a dedicated error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , lcapitulino@redhat.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com On 01/31/13 19:24, Peter Maydell wrote: > We should only be reporting one error: > "we failed because you asked for this bus and it's full" should > override the default "we failed to find this bus". We can fix > that by having the recursion stop as soon as we get an error. > I think the QMP caller should also only get one error. > Why does the qmp user need to get QERR_BUS_NOT_FOUND? > (it would be an incorrect error anyway in the case where > we have the GENERIC_ERROR text, because we have in fact found > the bus, we just couldn't use it.) That's a good clear goal which I can stick to -- let the first / innermost error (the one with the most specific human readable text usually) prevail, no matter the client type. Thanks! Laszlo