From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Release Candidates
Date: Fri, 01 Feb 2013 13:24:02 +0100 [thread overview]
Message-ID: <510BB3E2.6090109@suse.de> (raw)
In-Reply-To: <510545C4.3060001@suse.de>
Am 27.01.2013 16:20, schrieb Andreas Färber:
> Am 27.01.2013 16:16, schrieb Andreas Färber:
>> The automatic drop of -Werror during the RC phases has in the past led
>> to warnings creeping into submaintainer trees.
>>
>> Last QEMU Summit it was concluded that -Werror should stay on and
>> enabled only as part of the release process.
>
> be disabled, obviously :)
>
>> To relieve our release manager, instead of always enabling -Werror or
>> doing some number magic, let's enable it depending on whether a .git/
>> directory exists in the source tree.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
Big PING for rc0!
Andreas
>> ---
>> configure | 2 +-
>> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>>
>> diff --git a/configure b/configure
>> index b7635e4..0657b1a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1180,7 +1180,7 @@ fi
>> z_version=`cut -f3 -d. $source_path/VERSION`
>>
>> if test -z "$werror" ; then
>> - if test "$z_version" = "50" -a \
>> + if test -d "$source_path/.git" -a \
>> "$linux" = "yes" ; then
>> werror="yes"
>> else
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
parent reply other threads:[~2013-02-01 12:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <510545C4.3060001@suse.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510BB3E2.6090109@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).