* Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Release Candidates
[not found] ` <510545C4.3060001@suse.de>
@ 2013-02-01 12:24 ` Andreas Färber
0 siblings, 0 replies; only message in thread
From: Andreas Färber @ 2013-02-01 12:24 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
Am 27.01.2013 16:20, schrieb Andreas Färber:
> Am 27.01.2013 16:16, schrieb Andreas Färber:
>> The automatic drop of -Werror during the RC phases has in the past led
>> to warnings creeping into submaintainer trees.
>>
>> Last QEMU Summit it was concluded that -Werror should stay on and
>> enabled only as part of the release process.
>
> be disabled, obviously :)
>
>> To relieve our release manager, instead of always enabling -Werror or
>> doing some number magic, let's enable it depending on whether a .git/
>> directory exists in the source tree.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
Big PING for rc0!
Andreas
>> ---
>> configure | 2 +-
>> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>>
>> diff --git a/configure b/configure
>> index b7635e4..0657b1a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1180,7 +1180,7 @@ fi
>> z_version=`cut -f3 -d. $source_path/VERSION`
>>
>> if test -z "$werror" ; then
>> - if test "$z_version" = "50" -a \
>> + if test -d "$source_path/.git" -a \
>> "$linux" = "yes" ; then
>> werror="yes"
>> else
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] only message in thread