From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] fix scripts/make_device_config.sh
Date: Fri, 01 Feb 2013 14:38:09 +0100 [thread overview]
Message-ID: <510BC541.2020109@suse.de> (raw)
In-Reply-To: <1359720044-8140-3-git-send-email-kraxel@redhat.com>
Am 01.02.2013 13:00, schrieb Gerd Hoffmann:
> Make it handle multiple include statements in a file.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> scripts/make_device_config.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> index 0778fe2..81fe942 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -18,7 +18,7 @@ process_includes () {
>
> f=$src
> while [ -n "$f" ] ; do
> - f=`tr -d '\r' < $f | awk '/^include / {printf "'$src_dir'/%s", $2}'`
> + f=`cat $f | tr -d '\r' | awk '/^include / {printf "'$src_dir'/%s ", $2}'`
> [ $? = 0 ] || exit 1
> all_includes="$all_includes $f"
> done
The actual fix is appending a space? Or how does cat make a difference?
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-02-01 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 12:00 [Qemu-devel] [PATCH 0/4] usb: make devices configurable Gerd Hoffmann
2013-02-01 12:00 ` [Qemu-devel] [PATCH 1/4] usb: Makefile cleanup Gerd Hoffmann
2013-02-01 12:00 ` [Qemu-devel] [PATCH 2/4] fix scripts/make_device_config.sh Gerd Hoffmann
2013-02-01 13:38 ` Andreas Färber [this message]
2013-02-01 15:18 ` Gerd Hoffmann
2013-02-01 12:00 ` [Qemu-devel] [PATCH 3/4] make usb devices configurable Gerd Hoffmann
2013-02-01 21:37 ` Paolo Bonzini
2013-02-01 12:00 ` [Qemu-devel] [PATCH 4/4] allow disabling usb smartcard support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510BC541.2020109@suse.de \
--to=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).