From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Goq-00011x-5o
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 08:38:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Gom-00024i-1n
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 08:38:16 -0500
Received: from cantor2.suse.de ([195.135.220.15]:58872 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1U1Gol-00024b-RW
	for qemu-devel@nongnu.org; Fri, 01 Feb 2013 08:38:11 -0500
Message-ID: <510BC541.2020109@suse.de>
Date: Fri, 01 Feb 2013 14:38:09 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1359720044-8140-1-git-send-email-kraxel@redhat.com>
	<1359720044-8140-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1359720044-8140-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/4] fix scripts/make_device_config.sh
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Am 01.02.2013 13:00, schrieb Gerd Hoffmann:
> Make it handle multiple include statements in a file.
>=20
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  scripts/make_device_config.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config=
.sh
> index 0778fe2..81fe942 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -18,7 +18,7 @@ process_includes () {
> =20
>  f=3D$src
>  while [ -n "$f" ] ; do
> -  f=3D`tr -d '\r' < $f | awk '/^include / {printf "'$src_dir'/%s", $2}=
'`
> +  f=3D`cat $f | tr -d '\r' | awk '/^include / {printf "'$src_dir'/%s "=
, $2}'`
>    [ $? =3D 0 ] || exit 1
>    all_includes=3D"$all_includes $f"
>  done

The actual fix is appending a space? Or how does cat make a difference?

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg