From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1a6M-0004Mz-Ia for qemu-devel@nongnu.org; Sat, 02 Feb 2013 05:13:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1a6K-0004Zm-3X for qemu-devel@nongnu.org; Sat, 02 Feb 2013 05:13:38 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34820 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1a6J-0004Zd-Tn for qemu-devel@nongnu.org; Sat, 02 Feb 2013 05:13:36 -0500 Message-ID: <510CE6CA.3000804@suse.de> Date: Sat, 02 Feb 2013 11:13:30 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1359756196-5588-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1359756196-5588-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: blauwirbel@gmail.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, sw@weilnetz.de Am 01.02.2013 23:03, schrieb Paolo Bonzini: > We had two copies of a ffs function for longs with subtly different > semantics and, for the one in bitops.h, a confusing name: the result > was off-by-one compared to the library function ffsl. >=20 > Unify the functions into one, and solve the name problem by calling > the 0-based functions "bitops_ctzl" and "bitops_ctol" respectively. >=20 > This also fixes the build on platforms with ffsl, including Mac OS X > and Windows. >=20 > Signed-off-by: Paolo Bonzini Tested-by: Andreas F=E4rber This fixes the build on OpenIndiana, too. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg