From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1hvH-0001DM-VP for qemu-devel@nongnu.org; Sat, 02 Feb 2013 13:34:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1hvG-0000wu-Q2 for qemu-devel@nongnu.org; Sat, 02 Feb 2013 13:34:43 -0500 Message-ID: <510D5C3E.3040500@web.de> Date: Sat, 02 Feb 2013 19:34:38 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1359825474-26661-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1359825474-26661-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Am 02.02.2013 18:17, schrieb Peter Maydell: > Add explicit braces round an empty for-loop body; this fits > QEMU style and is easier to read than an inconspicuous semicolon > at the end of the line. It also silences a clang warning: > > disas/i386.c:4723:49: warning: for loop has empty body [-Wempty-body] > for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++); > ^ > disas/i386.c:4723:49: note: put the semicolon on a separate line to silence this warning [-Wempty-body] > > Signed-off-by: Peter Maydell > --- > This is the only clang warning on MacOSX apart from the ones about > deprecated features in audio/coreaudio.c and ui/cocoa.m, which is why > I think it's worth zapping despite it being a style issue in one of the > bits of disassembler code we got from binutils and which aren't generally > in QEMU style. > > checkpatch complains about the non-multiple-of-4 indent: > WARNING: suspect code indent for conditional statements (10, 10) > #27: FILE: disas/i386.c:4723: > + for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++) { > + } > > but I didn't see any value in reindenting the whole function just to > shut it up. > > At some point in the 1.5 cycle maybe we could update the code to avoid > the deprecated MacOS functions and then we could enable warnings-are-errors > on MacOS too. On v10.5.8 I'm seeing some redundant declaration warnings from disas/s390.c and assumed we wouldn't want to fix/workaround the disas stuff. Same for some exynos4 file. Also some uninitialized buf2 in the Realtek NIC or so. And test-thread-pool breaks due to undefined ___sync_fetch_and_add and ___sync_val_compare_and_swap. With my setup long broken due to pixman, we never made any progress fixing the main() mess - Stefan W. replaced asprintf in the command line code but I'd rather get rid of that in some way similar to here: http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg03983.html Cheers, Andreas