From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnCgd-0006xK-HW for qemu-devel@nongnu.org; Tue, 17 Jan 2012 12:19:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnCgb-0002Pt-Og for qemu-devel@nongnu.org; Tue, 17 Jan 2012 12:19:07 -0500 Received: from mail.serverraum.org ([78.47.150.89]:38273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnCgb-0002L2-CI for qemu-devel@nongnu.org; Tue, 17 Jan 2012 12:19:05 -0500 Message-ID: <511448918d064da5355fb24354497df2.squirrel@ssl.serverraum.org> Date: Tue, 17 Jan 2012 18:22:06 +0100 From: "Michael Walle" MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/6] qtest: add test framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi On Fri, January 13, 2012 19:32, Anthony Liguori wrote: > diff --git a/qtest.c b/qtest.c > new file mode 100644 > index 0000000..f41a9c3 > --- /dev/null > +++ b/qtest.c > @@ -0,0 +1,357 @@ > +/* > + * Test Server > + * > + * Copyright IBM, Corp. 2011 > + * > + * Authors: > + * Anthony Liguori > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + * > + */ > + > +#include "qtest.h" > +#include "qemu-char.h" > +#include "ioport.h" > +#include "memory.h" > +#include "hw/irq.h" > +#include "sysemu.h" > + > +#define MAX_IRQ 256 > + > +const char *qtest_chrdev; > +const char *qtest_log; > +int qtest_allowed =3D 0; > + > +static FILE *qtest_log_fp; > +static CharDriverState *qtest_chr; > +static GString *inbuf; > +static int irq_levels[MAX_IRQ]; > +static struct timeval start_time; > +static bool qtest_opened; > + > +#define FMT_timeval "%" PRId64 ".%06" PRId64 This doesnt work for me. tv_sec and tv_usec are "long int" on my platform (32bit, x86, debian stable). > + > +/** > + * QTest Protocol > + * > + * Line based protocol, request/response based. Server can send async messages > + * so clients should always handle many async messages before the resp= onse > + * comes in. > + * > + * Valid requests > + * > + * > outb ADDR VALUE > + * < OK > + * > + * > outw ADDR VALUE > + * < OK > + * > + * > outl ADDR VALUE > + * < OK > + * > + * > inb ADDR > + * < OK VALUE > + * > + * > inw ADDR > + * < OK VALUE > + * > + * > inl ADDR > + * < OK VALUE > + * > + * > read ADDR SIZE > + * < OK DATA > + * > + * > write ADDR SIZE DATA > + * < OK > + * > + * Valid async messages: > + * > + * IRQ raise NUM > + * IRQ lower NUM > + * > + * ADDR, SIZE, VALUE are all integers parsed with strtoul() with a bas= e of 0. > + * > + * DATA is an arbitrarily long hex number prefixed with '0x'. If it's smaller > + * than the expected size, the value will be zero filled at the end of the data > + * sequence. > + * > + * NUM is an IRQ number. > + */ > + > +static int hex2nib(char ch) > +{ > + if (ch >=3D '0' && ch <=3D '9') { > + return ch - '0'; > + } else if (ch >=3D 'a' && ch <=3D 'f') { > + return 10 + (ch - 'a'); > + } else if (ch >=3D 'A' && ch <=3D 'F') { > + return 10 + (ch - 'a'); > + } else { > + return -1; > + } > +} > + > +static void qtest_get_time(struct timeval *tv) > +{ > + gettimeofday(tv, NULL); > + tv->tv_sec -=3D start_time.tv_sec; > + tv->tv_usec -=3D start_time.tv_usec; > + if (tv->tv_usec < 0) { > + tv->tv_usec +=3D 1000000; > + tv->tv_sec -=3D 1; > + } > +} > + > +static void qtest_send_prefix(CharDriverState *chr) > +{ > + struct timeval tv; > + > + if (!qtest_log_fp || !qtest_opened) { > + return; > + } > + > + qtest_get_time(&tv); > + fprintf(qtest_log_fp, "[S +" FMT_timeval "] ", > + tv.tv_sec, tv.tv_usec); > +} > + > +static void qtest_send(CharDriverState *chr, const char *fmt, ...) +{ > + va_list ap; > + char buffer[1024]; > + size_t len; > + > + va_start(ap, fmt); > + len =3D vsnprintf(buffer, sizeof(buffer), fmt, ap); > + va_end(ap); > + > + qemu_chr_fe_write(chr, (uint8_t *)buffer, len); > + if (qtest_log_fp && qtest_opened) { > + fprintf(qtest_log_fp, "%s", buffer); > + } > +} > + > +static void qtest_process_command(CharDriverState *chr, gchar **words)= +{ > + const gchar *command; > + > + g_assert(words); > + > + command =3D words[0]; > + > + if (qtest_log_fp) { > + struct timeval tv; > + int i; > + > + qtest_get_time(&tv); > + fprintf(qtest_log_fp, "[R +" FMT_timeval "]", > + tv.tv_sec, tv.tv_usec); > + for (i =3D 0; words[i]; i++) { > + fprintf(qtest_log_fp, " %s", words[i]); > + } > + fprintf(qtest_log_fp, "\n"); > + } > + > + g_assert(command); i don't know if these asserts will be in the final version of your patch or wether one say that any protocol violations will terminate qemu. maybe we should just ignore unknown/invalid commands for now? Eg. i found it very useful to use the protocol directly with telnet but it was annoying that any invalid command aborted qemu. OTOH you may dictate to use a proper client library. i'm fine with this too ;) > + if (strcmp(words[0], "outb") =3D=3D 0 || > + strcmp(words[0], "outw") =3D=3D 0 || > + strcmp(words[0], "outl") =3D=3D 0) { > + uint16_t addr; > + uint32_t value; > + > + g_assert(words[1] && words[2]); > + addr =3D strtol(words[1], NULL, 0); > + value =3D strtol(words[2], NULL, 0); > + > + if (words[0][3] =3D=3D 'b') { > + cpu_outb(addr, value); > + } else if (words[0][3] =3D=3D 'w') { > + cpu_outw(addr, value); > + } else if (words[0][3] =3D=3D 'l') { > + cpu_outl(addr, value); > + } > + qtest_send_prefix(chr); > + qtest_send(chr, "OK\n"); > + } else if (strcmp(words[0], "inb") =3D=3D 0 || > + strcmp(words[0], "inw") =3D=3D 0 || > + strcmp(words[0], "inl") =3D=3D 0) { > + uint16_t addr; > + uint32_t value =3D -1U; > + > + g_assert(words[1]); > + addr =3D strtol(words[1], NULL, 0); > + > + if (words[0][2] =3D=3D 'b') { > + value =3D cpu_inb(addr); > + } else if (words[0][2] =3D=3D 'w') { > + value =3D cpu_inw(addr); > + } else if (words[0][2] =3D=3D 'l') { > + value =3D cpu_inl(addr); > + } > + qtest_send_prefix(chr); > + qtest_send(chr, "OK 0x%04x\n", value); > + } else if (strcmp(words[0], "read") =3D=3D 0) { > + uint64_t addr, len, i; > + uint8_t *data; > + > + g_assert(words[1] && words[2]); > + addr =3D strtoul(words[1], NULL, 0); > + len =3D strtoul(words[2], NULL, 0); > + > + data =3D g_malloc(len); > + cpu_physical_memory_read(addr, data, len); > + > + qtest_send_prefix(chr); > + qtest_send(chr, "OK 0x"); > + for (i =3D 0; i < len; i++) { > + qtest_send(chr, "%02x", data[i]); > + } > + qtest_send(chr, "\n"); > + > + g_free(data); > + } else if (strcmp(words[0], "write") =3D=3D 0) { > + uint64_t addr, len, i; > + uint8_t *data; > + size_t data_len; > + > + g_assert(words[1] && words[2] && words[3]); > + addr =3D strtoul(words[1], NULL, 0); > + len =3D strtoul(words[2], NULL, 0); > + > + data_len =3D strlen(words[3]); > + if (data_len < 3) { > + qtest_send(chr, "ERR invalid argument size\n"); > + return; > + } > + > + data =3D g_malloc(len); > + for (i =3D 0; i < len; i++) { > + if ((i * 2 + 4) <=3D data_len) { > + data[i] =3D hex2nib(words[3][i * 2 + 2]) << 4; > + data[i] |=3D hex2nib(words[3][i * 2 + 3]); > + } else { > + data[i] =3D 0; > + } > + } > + cpu_physical_memory_write(addr, data, len); > + g_free(data); > + > + qtest_send_prefix(chr); > + qtest_send(chr, "OK\n"); > + } else { > + fprintf(stderr, "Unknown command `%s'\n", words[0]); > + } > +} > + > +static void qtest_process_inbuf(CharDriverState *chr, GString *inbuf) = +{ > + char *end; > + > + while ((end =3D strchr(inbuf->str, '\n')) !=3D NULL) { > + size_t offset; > + GString *cmd; > + gchar **words; > + > + offset =3D end - inbuf->str; > + > + cmd =3D g_string_new_len(inbuf->str, offset); > + g_string_erase(inbuf, 0, offset + 1); > + > + words =3D g_strsplit(cmd->str, " ", 0); > + qtest_process_command(chr, words); > + g_strfreev(words); > + > + g_string_free(cmd, TRUE); > + } > +} > + > +static void qtest_read(void *opaque, const uint8_t *buf, int size) +{ > + CharDriverState *chr =3D opaque; > + > + g_string_append_len(inbuf, (const gchar *)buf, size); > + qtest_process_inbuf(chr, inbuf); > +} > + > +static int qtest_can_read(void *opaque) > +{ > + return 1024; > +} > + > +static void qtest_event(void *opaque, int event) > +{ > + int i; > + > + switch (event) { > + case CHR_EVENT_OPENED: > + qemu_system_reset(false); > + for (i =3D 0; i < ARRAY_SIZE(irq_levels); i++) { > + irq_levels[i] =3D 0; > + } > + gettimeofday(&start_time, NULL); > + qtest_opened =3D true; > + if (qtest_log_fp) { > + fprintf(qtest_log_fp, "[I " FMT_timeval "] OPENED\n", + = =20 start_time.tv_sec, start_time.tv_usec); > + } > + break; > + case CHR_EVENT_CLOSED: > + qtest_opened =3D false; > + if (qtest_log_fp) { > + struct timeval tv; > + qtest_get_time(&tv); > + fprintf(qtest_log_fp, "[I +" FMT_timeval "] CLOSED\n", + = =20 tv.tv_sec, tv.tv_usec); > + } > + break; > + default: > + break; > + } > +} > + > +static void qtest_set_irq(void *opaque, int irq, int level) > +{ > + CharDriverState *chr =3D qtest_chr; > + bool changed; > + > + changed =3D (irq_levels[irq] !=3D level); > + irq_levels[irq] =3D level; > + > + if (changed) { > + qtest_send_prefix(chr); > + qtest_send(chr, "IRQ %s %d\n", > + level ? "raise" : "lower", irq); > + } > +} > + > +qemu_irq *qtest_interrupt_controller_init(void) > +{ > + return qemu_allocate_irqs(qtest_set_irq, NULL, MAX_IRQ); > +} > + > +int qtest_init(void) > +{ > + CharDriverState *chr; > + > + g_assert(qtest_chrdev !=3D NULL); > + > + chr =3D qemu_chr_new("qtest", qtest_chrdev, NULL); chr may be NULL > + > + qemu_chr_add_handlers(chr, qtest_can_read, qtest_read, qtest_event= , chr); > + > + inbuf =3D g_string_new(""); > + > + if (qtest_log) { > + if (strcmp(qtest_log, "none") !=3D 0) { > + qtest_log_fp =3D fopen(qtest_log, "w+"); > + } > + } else { > + qtest_log_fp =3D stderr; > + } > + > + qtest_chr =3D chr; > + > + return 0; > +} > diff --git a/qtest.h b/qtest.h > new file mode 100644 > index 0000000..f0e1377 > --- /dev/null > +++ b/qtest.h > @@ -0,0 +1,37 @@ > +/* > + * Test Server > + * > + * Copyright IBM, Corp. 2011 > + * > + * Authors: > + * Anthony Liguori > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + * > + */ > + > +#ifndef QTEST_H > +#define QTEST_H > + > +#include "qemu-common.h" > + > +extern int qtest_allowed; > +extern const char *qtest_chrdev; > +extern const char *qtest_log; > + > +static inline bool qtest_enabled(void) > +{ > + return qtest_allowed; > +} > + > +static inline int qtest_available(void) > +{ > + return 1; > +} > + > +int qtest_init(void); > + > +qemu_irq *qtest_interrupt_controller_init(void); > + > +#endif > diff --git a/vl.c b/vl.c > index ba55b35..58fb5d9 100644 > --- a/vl.c > +++ b/vl.c > @@ -152,6 +152,7 @@ int main(int argc, char **argv) > #ifdef CONFIG_VIRTFS > #include "fsdev/qemu-fsdev.h" > #endif > +#include "qtest.h" > #include "disas.h" > @@ -1988,6 +1989,7 @@ static struct { > { "tcg", "tcg", tcg_available, tcg_init, &tcg_allowed }, > { "xen", "Xen", xen_available, xen_init, &xen_allowed }, > { "kvm", "KVM", kvm_available, kvm_init, &kvm_allowed }, > + { "qtest", "QTest", qtest_available, qtest_init, &qtest_allowed }, > }; > static int configure_accelerator(void) > @@ -3053,6 +3055,12 @@ int main(int argc, char **argv, char **envp) > fclose(fp); > break; > } > + case QEMU_OPTION_qtest: > + qtest_chrdev =3D optarg; > + break; > + case QEMU_OPTION_qtest_log: > + qtest_log =3D optarg; > + break; > default: > os_parse_cmd_args(popt->index, optarg); > } > -- > 1.7.4.1 --=20 michael