From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46ACEC33CB1 for ; Tue, 14 Jan 2020 08:52:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B4C82075B for ; Tue, 14 Jan 2020 08:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E5HYTmDw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B4C82075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irHwY-0008O3-8e for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 03:52:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52337) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irHvu-0007pj-Ii for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:52:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irHvt-0005Rk-L4 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:52:18 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:25014 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irHvt-0005RV-I0 for qemu-devel@nongnu.org; Tue, 14 Jan 2020 03:52:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578991936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KW6j/7/p9d/wFy990yfIHpRABNEtMDRdHbaaA/FwA8A=; b=E5HYTmDw0h1Xj2J1iWFihoIfBHjwO+bm5Pswhal9BHcMxUtJdU3q9riTRw5X57gTf3+pgE ETuLL2FRVmpxTPuhS6KXz0zMPCX8akTyLKKkfAXYIPaTWNVkZDbRzQqQmgdnfLEv707EuW cgNFlP3pcEKM9VNsN1kPzjxZOLxk+Ws= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-2nqhcLevOayN9BJ8Wrxxgw-1; Tue, 14 Jan 2020 03:52:09 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3232FDBA8; Tue, 14 Jan 2020 08:52:08 +0000 (UTC) Received: from [10.36.117.108] (ovpn-117-108.ams2.redhat.com [10.36.117.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B65C980F57; Tue, 14 Jan 2020 08:52:00 +0000 (UTC) Subject: Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers To: Peter Xu References: <20200109144319.15912-1-eric.auger@redhat.com> <20200109144319.15912-6-eric.auger@redhat.com> <20200113202301.GD201624@xz-x1> From: Auger Eric Message-ID: <51267d84-c805-a4a1-8084-b278721a5b3f@redhat.com> Date: Tue, 14 Jan 2020 09:51:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200113202301.GD201624@xz-x1> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 2nqhcLevOayN9BJ8Wrxxgw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, kevin.tian@intel.com, tnowicki@marvell.com, jean-philippe@linaro.org, quintela@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com, bharatb.linux@gmail.com, qemu-arm@nongnu.org, mst@redhat.com, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 1/13/20 9:23 PM, Peter Xu wrote: > On Thu, Jan 09, 2020 at 03:43:11PM +0100, Eric Auger wrote: > > [...] > >> +VirtIOIOMMUEndpoint *virtio_iommu_get_endpoint(VirtIOIOMMU *s, uint32_t ep_id); >> +VirtIOIOMMUEndpoint *virtio_iommu_get_endpoint(VirtIOIOMMU *s, uint32_t ep_id) > > Is the extra definition trying to workaround the compiler > warning/error? yes it does > > I'm not sure whether it's only me who prefer this, but again I'd > really perfer we move the function into the caller patch, add "static" > as needed altogether, even if that patch can be big. OK I will do that. > >> +{ >> + VirtIOIOMMUEndpoint *ep; >> + >> + ep = g_tree_lookup(s->endpoints, GUINT_TO_POINTER(ep_id)); >> + if (ep) { >> + return ep; >> + } >> + if (!virtio_iommu_mr(s, ep_id)) { > > Could I ask when this will trigger? This can happen when a device is attached to a domain and its RID does not correspond to one of the devices protected by the iommu. Thanks Eric > >> + return NULL; >> + } >> + ep = g_malloc0(sizeof(*ep)); >> + ep->id = ep_id; >> + trace_virtio_iommu_get_endpoint(ep_id); >> + g_tree_insert(s->endpoints, GUINT_TO_POINTER(ep_id), ep); >> + return ep; >> +} > > Thanks, >