From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBUck-00030M-1m for qemu-devel@nongnu.org; Fri, 01 Mar 2013 13:24:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UBUci-0000mk-SN for qemu-devel@nongnu.org; Fri, 01 Mar 2013 13:24:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UBUci-0000mc-Ht for qemu-devel@nongnu.org; Fri, 01 Mar 2013 13:24:00 -0500 Message-ID: <5130EA4B.4050504@redhat.com> Date: Fri, 01 Mar 2013 10:50:03 -0700 From: Eric Blake MIME-Version: 1.0 References: <1362130380-1895-1-git-send-email-lilei@linux.vnet.ibm.com> <1362130380-1895-3-git-send-email-lilei@linux.vnet.ibm.com> <5130E782.7080204@redhat.com> In-Reply-To: <5130E782.7080204@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2FINGXHSFNBKFJGFSCIDS" Subject: Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, aliguori@us.ibm.com, Lei Li , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FINGXHSFNBKFJGFSCIDS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/01/2013 10:38 AM, Eric Blake wrote: >> + error_setg_errno(errp, errno, "Invalid time %ld for overflow"= , >> + time_ns); >=20 > That wording sounds awkward. Worse, errno is NOT set to anything sane,= > so you do NOT want error_setg_errno. And %ld is wrong for int64_t on > 32-bit platforms. How about: >=20 > error_setg(errp, "Time %" PRI64D " is too large", time_ns); Don't know what I was thinking; there is no PRI64D. I meant PRId64. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2FINGXHSFNBKFJGFSCIDS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRMOpLAAoJEKeha0olJ0Nq/IQH/RN/L/u/ZODl4Z3d2cm85bqD aU1ojMuA0u6d9VlJklj5JnJLvGbZRDdhIMzrKdJ1rKv2PJW1CqXoMO4ZyBlt0fBF qulKmj74IsSiBK3YXdsRbxOKJgS3dW1sTgbb8oYqIBXmkIGZNPBc2+FaqFiIVTUt oh7e3NfgE3DOQj5zPhfdhxvHHPmFLNgmnl4YD2b1VOsYCShUDBE1YeMo/3KBkbzQ pD23vSpwJMtuskeFLsXk8IZL4jfJz2+jMZu/UN2C0d1kjrSlUYC4ZotEVbXpxzzd fNo6gKK/1aGjF7JLh9KIJulSCuQsA486VwxQ6KKX0whuUB4bRMbl7EtlMDRdSKc= =ep8s -----END PGP SIGNATURE----- ------enig2FINGXHSFNBKFJGFSCIDS--