From: Eric Blake <eblake@redhat.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze
Date: Fri, 01 Mar 2013 11:10:05 -0700 [thread overview]
Message-ID: <5130EEFD.7090009@redhat.com> (raw)
In-Reply-To: <1362160421-20637-1-git-send-email-mdroth@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On 03/01/2013 10:53 AM, Michael Roth wrote:
> We currently maintain a whitelist of commands that are safe during
> fsfreeze. During fsfreeze, we disable all commands that aren't part of
> that whitelist.
>
> guest-sync-delimited meets the criteria for being whitelisted, and is
> also required for qemu-ga clients that rely on guest-sync-delimited for
> re-syncing the channel after a timeout.
>
> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org
> ---
> qga/main.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qga/main.c b/qga/main.c
> index db281a5..ad75171 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -85,6 +85,7 @@ static const char *ga_freeze_whitelist[] = {
> "guest-ping",
> "guest-info",
> "guest-sync",
> + "guest-sync-delimited",
> "guest-fsfreeze-status",
> "guest-fsfreeze-thaw",
> NULL
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-01 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 17:53 [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze Michael Roth
2013-03-01 18:10 ` Eric Blake [this message]
2013-03-04 19:28 ` mdroth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5130EEFD.7090009@redhat.com \
--to=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).