From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCLD0-0005Dx-H0 for qemu-devel@nongnu.org; Sun, 03 Mar 2013 21:33:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCLCz-0001Tx-It for qemu-devel@nongnu.org; Sun, 03 Mar 2013 21:32:58 -0500 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:39577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCLCz-0001Ta-1o for qemu-devel@nongnu.org; Sun, 03 Mar 2013 21:32:57 -0500 Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Mar 2013 07:59:16 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 703EEE0050 for ; Mon, 4 Mar 2013 08:04:01 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r242Wlom29032614 for ; Mon, 4 Mar 2013 08:02:48 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r242Woui006510 for ; Mon, 4 Mar 2013 13:32:50 +1100 Message-ID: <5134075C.7070601@linux.vnet.ibm.com> Date: Mon, 04 Mar 2013 10:30:52 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1361875228-15769-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1361875228-15769-9-git-send-email-xiawenc@linux.vnet.ibm.com> <878v69hhl5.fsf@blackfin.pond.sub.org> <512EBD01.8010906@linux.vnet.ibm.com> In-Reply-To: <512EBD01.8010906@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 08/14] qmp: add interface query-images. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com >>> >>> ## >>> +# @query-images: >>> +# >>> +# Get a list of DeviceImageInfo for all virtual block devices. >> >> # Get block device image information >> > OK. > >>> +# >>> +# @device: #optional the name of the device to get image info from. If not >>> +# specified, all block devices will be queried >>> +# @backing: #optional true to show information on backing images, false or >>> +# omitted to show just the top image of a block device >> >> I'm not sure these flags are necessary. >> > These flag seems more flex to me. Always querying all info require > caller do a filter operation on what he got, but in many times caller > may be interested on only one device. > Coding for next version, I still feel flag may bring flexbility. Markus, are u OK with this? >>> +# >>> +# Returns: a list of @DeviceImageInfo describing each virtual block device >>> +# >>> +# Since: 1.5 >>> +## >>> +{ 'command': 'query-images', >>> + 'data': { '*device': 'str', '*backing': 'bool' }, >>> + 'returns': ['DeviceImageInfo'] } >>> + -- Best Regards Wenchao Xia