Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013-3-1 9:51, Wenchao Xia 写道:
> 于 2013-2-28 0:22, Kevin Wolf 写道:
>> Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben:
>>> Wenchao Xia <xiawenc@linux.vnet.ibm.com> writes:
>>>
>>>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>>> ---
>>>>   block.c               |   24 ++++++++++++++++++++++++
>>>>   include/block/block.h |    2 ++
>>>>   savevm.c              |   22 ----------------------
>>>>   3 files changed, 26 insertions(+), 22 deletions(-)
>>>
>>> Perhaps savevm.c isn't the best home for snapshot stuff, but I don't
>>> like it in block.c any better.  block.c is already unwieldy, and I'd
>>> like us to try limiting it to core block stuff.
>>>
>>> Kevin, Stefan, any ideas?
>>
>> Take some more snapshot related functions from block.c and move them to
>> block/snapshot.c?
>>
>> Kevin
>>
> Hi, Stefan
>    Do you also agree about adding new file block/snapshot.c?
>
>
Hi,
   I am going to add include/block/snapshot.h and block/snapshot.c,
all internal snapshot function in block.c will be moved there.
external backing file related function will not be touched and
remain in block.c. This consume many effort and once done it will
be hard to revert back to form an incremental commit in this
serials, so before coding, please give your opinion if u don't agree
about it.

-- 
Best Regards

Wenchao Xia